ramips: fix reading mac address for hiwifi hc5962
authorTianling Shen <cnsztl@immortalwrt.org>
Sun, 2 Mar 2025 12:06:49 +0000 (20:06 +0800)
committerHauke Mehrtens <hauke@hauke-m.de>
Sat, 8 Mar 2025 19:12:11 +0000 (20:12 +0100)
The spaces in variables have been stripped since commit 551e04f3c9c0
("base-files: strip space and tab characters from ASCII mac address"),
resulting "Vfac_mac " matches nothing. Fix the issue by removing the
space at end.

Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
Link: https://github.com/openwrt/openwrt/pull/18150
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
target/linux/ramips/mt7621/base-files/etc/board.d/02_network
target/linux/ramips/mt7621/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac

index 650fef62a846ef7914edbb945155104ef4d1719c..682b75ab5c2a24ebd005e3ff109fc5dc2065a9ff 100644 (file)
@@ -264,7 +264,7 @@ ramips_setup_macs()
                wan_mac=$label_mac
                ;;
        hiwifi,hc5962)
-               lan_mac=$(mtd_get_mac_ascii bdinfo "Vfac_mac ")
+               lan_mac=$(mtd_get_mac_ascii bdinfo "Vfac_mac")
                label_mac=$lan_mac
                [ -n "$lan_mac" ] || lan_mac=$(cat /sys/class/net/eth0/address)
                wan_mac=$(macaddr_add "$lan_mac" 1)
index 16c5dfc09bd5d8cd75230227b7af93edcc7de271..4f19e2a4eb8c36336db23f324adf471747f02bd1 100644 (file)
@@ -103,7 +103,7 @@ case "$board" in
                        macaddr_setbit_la "$(mtd_get_mac_binary factory 0x4)" > /sys${DEVPATH}/macaddress
                ;;
        hiwifi,hc5962)
-               label_mac=$(mtd_get_mac_ascii bdinfo "Vfac_mac ")
+               label_mac=$(mtd_get_mac_ascii bdinfo "Vfac_mac")
                [ "$PHYNBR" = "0" ] && [ -n "$label_mac" ] && \
                echo -n "$label_mac" > /sys${DEVPATH}/macaddress
                [ "$PHYNBR" = "1" ] && [ -n "$label_mac" ] && \