ASoC: rt700: fix return value check in rt700_sdw_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 15 Jan 2020 14:30:27 +0000 (14:30 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 17 Jan 2020 15:30:59 +0000 (15:30 +0000)
In case of error, the function devm_regmap_init() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: 7d2a5f9ae41e ("ASoC: rt700: add rt700 codec driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200115143027.94364-1-weiyongjun1@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt700-sdw.c

index 314103601af3ef73c14baf96590313bafa9fcbc2..a4b95425886f900bef749303cf740f4285996db4 100644 (file)
@@ -460,8 +460,8 @@ static int rt700_sdw_probe(struct sdw_slave *slave,
 
        regmap = devm_regmap_init(&slave->dev, NULL,
                &slave->dev, &rt700_regmap);
-       if (!regmap)
-               return -EINVAL;
+       if (IS_ERR(regmap))
+               return PTR_ERR(regmap);
 
        rt700_init(&slave->dev, sdw_regmap, regmap, slave);