smsc: replace WARN_ON() with WARN_ON_SMP()
authorSanjeev Sharma <sanjeev_sharma@mentor.com>
Mon, 11 Aug 2014 08:16:23 +0000 (13:46 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Aug 2014 21:38:29 +0000 (14:38 -0700)
spin_is_locked() always return false in uniprocessor configuration and therefore it
would be advise to repalce with WARN_ON_SMP().

Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/smsc/smsc911x.h

index 23953957fed8a37e7e8daa81d6474e9d33b5413d..54d648920a1b9dfcb5d4f5a01271784e7df8723c 100644 (file)
@@ -51,7 +51,7 @@
 
 #ifdef CONFIG_DEBUG_SPINLOCK
 #define SMSC_ASSERT_MAC_LOCK(pdata) \
-               WARN_ON(!spin_is_locked(&pdata->mac_lock))
+               WARN_ON_SMP(!spin_is_locked(&pdata->mac_lock))
 #else
 #define SMSC_ASSERT_MAC_LOCK(pdata) do {} while (0)
 #endif                         /* CONFIG_DEBUG_SPINLOCK */