ibmvnic: Do not close unopened driver during reset
authorThomas Falcon <tlfalcon@linux.ibm.com>
Fri, 7 Jun 2019 21:03:53 +0000 (16:03 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 Jun 2019 02:51:28 +0000 (19:51 -0700)
Check driver state before halting it during a reset. If the driver is
not running, do nothing. Otherwise, a request to deactivate a down link
can cause an error and the reset will fail.

Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c

index 3da392bfd6594fe9c2fdb2105131e5324352eee0..bc2a91205eeca15e53bfd70bd816c50714541b41 100644 (file)
@@ -1745,7 +1745,8 @@ static int do_reset(struct ibmvnic_adapter *adapter,
 
        ibmvnic_cleanup(netdev);
 
-       if (adapter->reset_reason != VNIC_RESET_MOBILITY &&
+       if (reset_state == VNIC_OPEN &&
+           adapter->reset_reason != VNIC_RESET_MOBILITY &&
            adapter->reset_reason != VNIC_RESET_FAILOVER) {
                rc = __ibmvnic_close(netdev);
                if (rc)