platform/x86: intel_pmc_core: Fix file permission warnings
authorRajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Thu, 11 Jan 2018 11:10:35 +0000 (16:40 +0530)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 16 Jan 2018 15:24:15 +0000 (17:24 +0200)
Symbolic permissions 'S_IRUGO' are not preferred. This patch changes the
debugfs files to use octal permissions '0644' or '0444' as needed by the
attribute.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel_pmc_core.c

index 44353034718abb361bd97dadb53d94852370f191..cf8b3b34a97937a0e7fe215c11d49d0e6bfa422e 100644 (file)
@@ -414,31 +414,27 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
                return -ENOMEM;
 
        pmcdev->dbgfs_dir = dir;
-       file = debugfs_create_file("slp_s0_residency_usec", S_IFREG | S_IRUGO,
+       file = debugfs_create_file("slp_s0_residency_usec", 0444,
                                   dir, pmcdev, &pmc_core_dev_state);
        if (!file)
                goto err;
 
-       file = debugfs_create_file("pch_ip_power_gating_status",
-                                  S_IFREG | S_IRUGO, dir, pmcdev,
-                                  &pmc_core_ppfear_ops);
+       file = debugfs_create_file("pch_ip_power_gating_status", 0444,
+                                  dir, pmcdev, &pmc_core_ppfear_ops);
        if (!file)
                goto err;
 
-       file = debugfs_create_file("mphy_core_lanes_power_gating_status",
-                                  S_IFREG | S_IRUGO, dir, pmcdev,
-                                  &pmc_core_mphy_pg_ops);
+       file = debugfs_create_file("mphy_core_lanes_power_gating_status", 0444,
+                                  dir, pmcdev, &pmc_core_mphy_pg_ops);
        if (!file)
                goto err;
 
-       file = debugfs_create_file("pll_status",
-                                  S_IFREG | S_IRUGO, dir, pmcdev,
+       file = debugfs_create_file("pll_status", 0444, dir, pmcdev,
                                   &pmc_core_pll_ops);
        if (!file)
                goto err;
 
-       file = debugfs_create_file("ltr_ignore",
-                                  S_IFREG | S_IRUGO, dir, pmcdev,
+       file = debugfs_create_file("ltr_ignore", 0644, dir, pmcdev,
                                   &pmc_core_ltr_ignore_ops);
 
        if (!file)