net/mlx5e: Allow vlans on e-switch uplink reps
authorOr Gerlitz <ogerlitz@mellanox.com>
Tue, 18 Dec 2018 11:32:46 +0000 (13:32 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Thu, 20 Dec 2018 13:06:01 +0000 (05:06 -0800)
There are cases (e.g tunneling with vlan on underlay and potentially
more) where this makes sense, so allow that.

Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Eli Britstein <elibr@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

index 18d0f4f7537b81b01f1eaafbc4394402e3bba388..91c3eb85f32eb74b6fbed742f687a76c032ce02e 100644 (file)
@@ -1381,7 +1381,7 @@ static void mlx5e_build_rep_netdev(struct net_device *netdev)
 
        netdev->switchdev_ops = &mlx5e_rep_switchdev_ops;
 
-       netdev->features         |= NETIF_F_VLAN_CHALLENGED | NETIF_F_HW_TC | NETIF_F_NETNS_LOCAL;
+       netdev->features         |= NETIF_F_HW_TC | NETIF_F_NETNS_LOCAL;
        netdev->hw_features      |= NETIF_F_HW_TC;
 
        netdev->hw_features    |= NETIF_F_SG;
@@ -1392,6 +1392,9 @@ static void mlx5e_build_rep_netdev(struct net_device *netdev)
        netdev->hw_features    |= NETIF_F_TSO6;
        netdev->hw_features    |= NETIF_F_RXCSUM;
 
+       if (rep->vport != FDB_UPLINK_VPORT)
+               netdev->features |= NETIF_F_VLAN_CHALLENGED;
+
        netdev->features |= netdev->hw_features;
 }