projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c283661
)
ALSA: powermac: Deletion of an unnecessary check before the function call "pci_dev_put"
author
Markus Elfring
<elfring@users.sourceforge.net>
Mon, 17 Nov 2014 12:35:54 +0000
(13:35 +0100)
committer
Takashi Iwai
<tiwai@suse.de>
Mon, 17 Nov 2014 12:52:45 +0000
(13:52 +0100)
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/pmac.c
patch
|
blob
|
history
diff --git
a/sound/ppc/pmac.c
b/sound/ppc/pmac.c
index 8a431bcb056cecc5414ba30e93c238fce7288df9..5a13b22748b217b08571cdd90d3f8a8078ac8223 100644
(file)
--- a/
sound/ppc/pmac.c
+++ b/
sound/ppc/pmac.c
@@
-887,8
+887,7
@@
static int snd_pmac_free(struct snd_pmac *chip)
}
}
- if (chip->pdev)
- pci_dev_put(chip->pdev);
+ pci_dev_put(chip->pdev);
of_node_put(chip->node);
kfree(chip);
return 0;