power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request
authorValentin Rothberg <Valentin.Rothberg@lip6.fr>
Mon, 2 Mar 2015 14:32:48 +0000 (15:32 +0100)
committerSebastian Reichel <sre@kernel.org>
Mon, 2 Mar 2015 20:54:48 +0000 (21:54 +0100)
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request may fail.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/smb347-charger.c

index acf84e80fe986c2c577f7b0d789510c62801c9c1..e9702de262e512bbda6a56bbf0e11072c344f6df 100644 (file)
@@ -842,7 +842,8 @@ static int smb347_irq_init(struct smb347_charger *smb,
                goto fail;
 
        ret = request_threaded_irq(irq, NULL, smb347_interrupt,
-                                  IRQF_TRIGGER_FALLING, client->name, smb);
+                                  IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+                                  client->name, smb);
        if (ret < 0)
                goto fail_gpio;