HID: use BIT macro instead of plain integers for flags
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tue, 20 Mar 2018 11:04:47 +0000 (12:04 +0100)
committerJiri Kosina <jkosina@suse.cz>
Fri, 23 Mar 2018 14:44:57 +0000 (15:44 +0100)
This can lead to some hairy situation with the developer losing
a day or two realizing that 4 should be after 2, not 3.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
--
 include/linux/hid.h | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
include/linux/hid.h

index 091a81cf330ff91925c60bb4b32c333b35a49bfe..d104f2ebc809548fde8ba2d42e2d28ddc556d726 100644 (file)
@@ -26,6 +26,7 @@
 #define __HID_H
 
 
+#include <linux/bitops.h>
 #include <linux/types.h>
 #include <linux/slab.h>
 #include <linux/list.h>
@@ -494,13 +495,13 @@ struct hid_output_fifo {
        char *raw_report;
 };
 
-#define HID_CLAIMED_INPUT      1
-#define HID_CLAIMED_HIDDEV     2
-#define HID_CLAIMED_HIDRAW     4
-#define HID_CLAIMED_DRIVER     8
+#define HID_CLAIMED_INPUT      BIT(0)
+#define HID_CLAIMED_HIDDEV     BIT(1)
+#define HID_CLAIMED_HIDRAW     BIT(2)
+#define HID_CLAIMED_DRIVER     BIT(3)
 
-#define HID_STAT_ADDED         1
-#define HID_STAT_PARSED                2
+#define HID_STAT_ADDED         BIT(0)
+#define HID_STAT_PARSED                BIT(1)
 
 struct hid_input {
        struct list_head list;