drm/amd/powerplay: Minor fixes in processpptables.c (v2)
authorErnst Sjöstrand <ernstp@gmail.com>
Sun, 19 Nov 2017 17:52:42 +0000 (18:52 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 6 Dec 2017 17:47:59 +0000 (12:47 -0500)
Reported by smatch:
init_overdrive_limits() error: uninitialized symbol 'result'.
get_clock_voltage_dependency_table() warn: inconsistent indenting

v2: set result to 0 (Alex)

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Ernst Sjöstrand <ernstp@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c

index afae32ee2b0d676ea87c038971c2ad6e8c763798..c3e7e34535e8c1ee299282b286763b7fb0ebf062 100644 (file)
@@ -394,8 +394,8 @@ static int get_clock_voltage_dependency_table(struct pp_hwmgr *hwmgr,
                dep_table->entries[i].clk =
                        ((unsigned long)table->entries[i].ucClockHigh << 16) |
                        le16_to_cpu(table->entries[i].usClockLow);
-                       dep_table->entries[i].v =
-                               (unsigned long)le16_to_cpu(table->entries[i].usVoltage);
+               dep_table->entries[i].v =
+                       (unsigned long)le16_to_cpu(table->entries[i].usVoltage);
        }
 
        *ptable = dep_table;
@@ -1042,7 +1042,7 @@ static int init_overdrive_limits_V2_1(struct pp_hwmgr *hwmgr,
 static int init_overdrive_limits(struct pp_hwmgr *hwmgr,
                        const ATOM_PPLIB_POWERPLAYTABLE *powerplay_table)
 {
-       int result;
+       int result = 0;
        uint8_t frev, crev;
        uint16_t size;