net/9p: convert to idr_alloc()
authorTejun Heo <tj@kernel.org>
Thu, 28 Feb 2013 01:04:57 +0000 (17:04 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 Feb 2013 03:10:20 +0000 (19:10 -0800)
Convert to the much saner new idr interface.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@sandia.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
net/9p/util.c

index 6ceeeb384de73cbd4583b9b22a41c27b8b0885bb..59f278e64f584b726225fdf02a5f4a88f18fca0e 100644 (file)
@@ -87,23 +87,18 @@ EXPORT_SYMBOL(p9_idpool_destroy);
 
 int p9_idpool_get(struct p9_idpool *p)
 {
-       int i = 0;
-       int error;
+       int i;
        unsigned long flags;
 
-retry:
-       if (idr_pre_get(&p->pool, GFP_NOFS) == 0)
-               return -1;
-
+       idr_preload(GFP_NOFS);
        spin_lock_irqsave(&p->lock, flags);
 
        /* no need to store exactly p, we just need something non-null */
-       error = idr_get_new(&p->pool, p, &i);
-       spin_unlock_irqrestore(&p->lock, flags);
+       i = idr_alloc(&p->pool, p, 0, 0, GFP_NOWAIT);
 
-       if (error == -EAGAIN)
-               goto retry;
-       else if (error)
+       spin_unlock_irqrestore(&p->lock, flags);
+       idr_preload_end();
+       if (i < 0)
                return -1;
 
        p9_debug(P9_DEBUG_MUX, " id %d pool %p\n", i, p);