drm/exynos/ipp: remove incorrect checks of list_first_entry result
authorAndrzej Hajda <a.hajda@samsung.com>
Thu, 3 Jul 2014 13:10:31 +0000 (15:10 +0200)
committerInki Dae <daeinki@gmail.com>
Sun, 3 Aug 2014 07:52:18 +0000 (16:52 +0900)
list_first_entry does not return NULL on empty list so this check
does not make sense. Moreover there is already code which prevents calling
list_first_entry on empty lists.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_ipp.c

index f84ef8a905923cfa4f7ae452f70ef8eae138b834..89ff7e34a6fb8d4fe1e0751e57565db67b0e1d52 100644 (file)
@@ -1277,11 +1277,6 @@ static int ipp_start_property(struct exynos_drm_ippdrv *ippdrv,
 
                        m_node = list_first_entry(head,
                                struct drm_exynos_ipp_mem_node, list);
-                       if (!m_node) {
-                               DRM_ERROR("failed to get node.\n");
-                               ret = -EFAULT;
-                               goto err_unlock;
-                       }
 
                        DRM_DEBUG_KMS("m_node[0x%x]\n", (int)m_node);
 
@@ -1539,11 +1534,6 @@ static int ipp_send_event(struct exynos_drm_ippdrv *ippdrv,
 
                        m_node = list_first_entry(head,
                                struct drm_exynos_ipp_mem_node, list);
-                       if (!m_node) {
-                               DRM_ERROR("empty memory node.\n");
-                               ret = -ENOMEM;
-                               goto err_mem_unlock;
-                       }
 
                        tbuf_id[i] = m_node->buf_id;
                        DRM_DEBUG_KMS("%s buf_id[%d]\n",
@@ -1580,11 +1570,6 @@ static int ipp_send_event(struct exynos_drm_ippdrv *ippdrv,
 
                m_node = list_first_entry(head,
                        struct drm_exynos_ipp_mem_node, list);
-               if (!m_node) {
-                       DRM_ERROR("empty memory node.\n");
-                       ret = -ENOMEM;
-                       goto err_mem_unlock;
-               }
 
                tbuf_id[EXYNOS_DRM_OPS_SRC] = m_node->buf_id;