dm mpath: move dm_bio_restore out of endio method
authorMike Snitzer <snitzer@redhat.com>
Wed, 6 Dec 2017 21:08:14 +0000 (16:08 -0500)
committerMike Snitzer <snitzer@redhat.com>
Wed, 3 Jan 2018 14:27:40 +0000 (09:27 -0500)
Moving the dm_bio_restore() to process_queued_bios() avoids doing that
work in multipath_end_io_bio().

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-mpath.c

index 40d721df11d316e66041100b19bd86054c763baf..45e9044d3bb5a30db72aa79699a86ad14fb188d7 100644 (file)
@@ -639,7 +639,9 @@ static void process_queued_bios(struct work_struct *work)
 
        blk_start_plug(&plug);
        while ((bio = bio_list_pop(&bios))) {
-               r = __multipath_map_bio(m, bio, get_mpio_from_bio(bio));
+               struct dm_mpath_io *mpio = get_mpio_from_bio(bio);
+               dm_bio_restore(get_bio_details_from_mpio(mpio), bio);
+               r = __multipath_map_bio(m, bio, mpio);
                switch (r) {
                case DM_MAPIO_KILL:
                        bio->bi_status = BLK_STS_IOERR;
@@ -1551,9 +1553,6 @@ static int multipath_end_io_bio(struct dm_target *ti, struct bio *clone,
                goto done;
        }
 
-       /* Queue for the daemon to resubmit */
-       dm_bio_restore(get_bio_details_from_mpio(mpio), clone);
-
        spin_lock_irqsave(&m->lock, flags);
        bio_list_add(&m->queued_bios, clone);
        spin_unlock_irqrestore(&m->lock, flags);