RDMA/netlink: Add and implement doit netlink callback

The .doit callback is used by netlink core to differentiate
between get and set operations. Common convention is to use
that call for command operations like (SET, ADD, e.t.c.) and/or
access without NLF_M_DUMP flag.

This commit adds proper declaration and implementation
to RDMA netlink.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>

diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
index a7082adae16b7ef0f804843080f19beb8e9f5a69..484d6a8a2811a120cc8732b7212ce99604af68ab 100644 (file)
--- a/drivers/infiniband/core/netlink.c
+++ b/drivers/infiniband/core/netlink.c
@@ -76,9 +76,13 @@ static bool is_nl_msg_valid(unsigned int type, unsigned int op)
 
 static bool is_nl_valid(unsigned int type, unsigned int op)
 {
-       if (!is_nl_msg_valid(type, op) ||
-           !rdma_nl_types[type].cb_table ||
-           !rdma_nl_types[type].cb_table[op].dump)
+       const struct rdma_nl_cbs *cb_table;
+
+       if (!is_nl_msg_valid(type, op))
+               return false;
+
+       cb_table = rdma_nl_types[type].cb_table;
+       if (!cb_table || (!cb_table[op].dump && !cb_table[op].doit))
                return false;
        return true;
 }
@@ -151,6 +155,7 @@ static int rdma_nl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
        unsigned int op = RDMA_NL_GET_OP(type);
        struct netlink_callback cb = {};
        struct netlink_dump_control c = {};
+       int ret;
 
        if (!is_nl_valid(index, op))
                return -EINVAL;
@@ -169,10 +174,14 @@ static int rdma_nl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
                cb.nlh = nlh;
                cb.dump = rdma_nl_types[index].cb_table[op].dump;
                return cb.dump(skb, &cb);
+       } else {
+               c.dump = rdma_nl_types[index].cb_table[op].dump;
+               return netlink_dump_start(nls, skb, nlh, &c);
        }
+       if (rdma_nl_types[index].cb_table[op].doit)
+               ret = rdma_nl_types[index].cb_table[op].doit(skb, nlh, extack);
+       return ret;
 
-       c.dump = rdma_nl_types[index].cb_table[op].dump;
-       return netlink_dump_start(nls, skb, nlh, &c);
 }
 
 /*

diff --git a/include/rdma/rdma_netlink.h b/include/rdma/rdma_netlink.h
index 92f8832297abb8477e649b5dd301e6114cd401fa..e25bf1988846df869dbb285032fbf201d0dd6864 100644 (file)
--- a/include/rdma/rdma_netlink.h
+++ b/include/rdma/rdma_netlink.h
@@ -6,6 +6,8 @@
 #include <uapi/rdma/rdma_netlink.h>
 
 struct rdma_nl_cbs {
+       int (*doit)(struct sk_buff *skb, struct nlmsghdr *nlh,
+                   struct netlink_ext_ack *extack);
        int (*dump)(struct sk_buff *skb, struct netlink_callback *nlcb);
        u8 flags;
 };