ASoC: stm: Drop superfluous PCM preallocation error checks
authorTakashi Iwai <tiwai@suse.de>
Mon, 4 Feb 2019 15:40:22 +0000 (16:40 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 6 Feb 2019 17:29:28 +0000 (18:29 +0100)
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant.  Drop it.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/soc/stm/stm32_adfsdm.c

index 706ff005234f34f04bb586d076503855e84d8b08..47901983a6ff88706dd847376a42d5aeb2c3a4c6 100644 (file)
@@ -262,8 +262,9 @@ static int stm32_adfsdm_pcm_new(struct snd_soc_pcm_runtime *rtd)
                snd_soc_dai_get_drvdata(rtd->cpu_dai);
        unsigned int size = DFSDM_MAX_PERIODS * DFSDM_MAX_PERIOD_SIZE;
 
-       return snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
-                                                    priv->dev, size, size);
+       snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+                                             priv->dev, size, size);
+       return 0;
 }
 
 static void stm32_adfsdm_pcm_free(struct snd_pcm *pcm)