prctl: make PR_SET_THP_DISABLE wait for mmap_sem killable
authorMichal Hocko <mhocko@suse.com>
Mon, 23 May 2016 23:26:05 +0000 (16:26 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 24 May 2016 00:04:14 +0000 (17:04 -0700)
PR_SET_THP_DISABLE requires mmap_sem for write.  If the waiting task
gets killed by the oom killer it would block oom_reaper from
asynchronous address space reclaim and reduce the chances of timely OOM
resolving.  Wait for the lock in the killable mode and return with EINTR
if the task got killed while waiting.

Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Alex Thorlton <athorlton@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/sys.c

index cf8ba545c7d3ba6feda038455d75d1931194f3e9..89d5be418157fa7a18760b57c11a56a7437c8b81 100644 (file)
@@ -2246,7 +2246,8 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3,
        case PR_SET_THP_DISABLE:
                if (arg3 || arg4 || arg5)
                        return -EINVAL;
-               down_write(&me->mm->mmap_sem);
+               if (down_write_killable(&me->mm->mmap_sem))
+                       return -EINTR;
                if (arg2)
                        me->mm->def_flags |= VM_NOHUGEPAGE;
                else