mfd: wm8350-core: Fix probable mask then right shift defect

Precedence of & and >> is not the same and is not left to right.
shift has higher precedence and should be done after the mask.

Add parentheses around the mask.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
index 4ab527f5c53b65ff2872ba07fcef30982a390f3a..f5124a8acad8e06fb8344c718b42d1048a37c455 100644 (file)
--- a/drivers/mfd/wm8350-core.c
+++ b/drivers/mfd/wm8350-core.c
@@ -308,7 +308,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,
                goto err;
        }
 
-       mode = id2 & WM8350_CONF_STS_MASK >> 10;
+       mode = (id2 & WM8350_CONF_STS_MASK) >> 10;
        cust_id = id2 & WM8350_CUST_ID_MASK;
        chip_rev = (id2 & WM8350_CHIP_REV_MASK) >> 12;
        dev_info(wm8350->dev,