ionic: no link check until after probe
authorShannon Nelson <snelson@pensando.io>
Thu, 30 Apr 2020 21:33:41 +0000 (14:33 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 May 2020 01:02:46 +0000 (18:02 -0700)
Don't bother with the link check during probe, let
the watchdog notice the first link-up.  This allows
probe to finish cleanly without any interruptions
from over excited user programs opening the device
as soon as it is registered.

Fixes: c672412f6172 ("ionic: remove lifs on fw reset")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pensando/ionic/ionic_lif.c

index 5acf4f46c268b96f973ece41a36e6e185a10c704..bbc6c79e0f042986255c2ec70f450315dc182a6c 100644 (file)
@@ -2549,8 +2549,6 @@ int ionic_lifs_register(struct ionic *ionic)
                dev_err(ionic->dev, "Cannot register net device, aborting\n");
                return err;
        }
-
-       ionic_link_status_check_request(ionic->master_lif);
        ionic->master_lif->registered = true;
 
        return 0;