projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6f93b9c
)
[VLAN] net/8021q/vlanproc.c: fix check-after-use
author
Adrian Bunk
<bunk@kernel.org>
Wed, 15 Aug 2007 00:39:43 +0000
(17:39 -0700)
committer
David S. Miller
<davem@davemloft.net>
Wed, 15 Aug 2007 00:39:43 +0000
(17:39 -0700)
The Coverity checker spotted that we'd have already oops'ed if
"vlandev" was NULL.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/8021q/vlanproc.c
patch
|
blob
|
history
diff --git
a/net/8021q/vlanproc.c
b/net/8021q/vlanproc.c
index c0040c9064a144a0f7afb3e47411eaed6ce13576..bd08aa090763ad469e7e9c795f8057d8370e46f0 100644
(file)
--- a/
net/8021q/vlanproc.c
+++ b/
net/8021q/vlanproc.c
@@
-319,7
+319,7
@@
static int vlandev_seq_show(struct seq_file *seq, void *offset)
static const char fmt[] = "%30s %12lu\n";
int i;
- if (
(vlandev == NULL) || (!(vlandev->priv_flags & IFF_802_1Q_VLAN)
))
+ if (
!(vlandev->priv_flags & IFF_802_1Q_VLAN
))
return 0;
seq_printf(seq, "%s VID: %d REORDER_HDR: %i dev->priv_flags: %hx\n",