drm/i915/gt: Move new timelines to the end of active_list
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 19 Nov 2019 16:25:58 +0000 (16:25 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 19 Nov 2019 16:46:58 +0000 (16:46 +0000)
When adding a new active timeline, place it at the end of the list. This
allows for intel_gt_retire_requests() to pick up the newcomer more
quickly and hopefully complete the retirement sooner. A miniscule
optimisation.

References: 7936a22dd466 ("drm/i915/gt: Wait for new requests in intel_gt_retire_requests()")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191119162559.3313003-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_timeline.c

index 16a9e88d93de5854d50ce30e6ffac954d77140af..0e277835aad05f4fc7e0f828e9c81e069a84a33b 100644 (file)
@@ -342,7 +342,7 @@ void intel_timeline_enter(struct intel_timeline *tl)
        GEM_BUG_ON(!tl->active_count); /* overflow? */
 
        spin_lock_irqsave(&timelines->lock, flags);
-       list_add(&tl->link, &timelines->active_list);
+       list_add_tail(&tl->link, &timelines->active_list);
        spin_unlock_irqrestore(&timelines->lock, flags);
 }