Input: cyapa - mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 15 Oct 2018 18:21:18 +0000 (11:21 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 15 Oct 2018 18:24:10 +0000 (11:24 -0700)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced the "Fallthrough state"
commern with a proper "Fall through", which is what GCC is expecting to
find.

Addresses-Coverity-ID: 114758 ("Missing break in switch")
Addresses-Coverity-ID: 114759 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/cyapa_gen3.c

index 076dda4a66da14025e8680c6283fb1fb186d2c80..00e395dfc3d5ae6ec6b5f85b7b88878a356e9d90 100644 (file)
@@ -1067,7 +1067,7 @@ static int cyapa_gen3_do_operational_check(struct cyapa *cyapa)
                        return error;
                }
 
-       /* Fallthrough state */
+       /* Fall through */
        case CYAPA_STATE_BL_IDLE:
                /* Try to get firmware version in bootloader mode. */
                cyapa_gen3_bl_query_data(cyapa);
@@ -1078,7 +1078,7 @@ static int cyapa_gen3_do_operational_check(struct cyapa *cyapa)
                        return error;
                }
 
-       /* Fallthrough state */
+       /* Fall through */
        case CYAPA_STATE_OP:
                /*
                 * Reading query data before going back to the full mode