Staging: crystalhd: fix device_create() return value check
authorJani Nikula <ext-jani.1.nikula@nokia.com>
Thu, 11 Mar 2010 16:22:51 +0000 (18:22 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 11 May 2010 18:35:36 +0000 (11:35 -0700)
Use IS_ERR() instead of comparing to NULL.

Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Cc: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/crystalhd/crystalhd_lnx.c

index 54bad652c0c5022c195c6ca22c9881d8a778cc10..3c562f0f86b3642b98c57ad2dca8ea0538d611ef 100644 (file)
@@ -376,7 +376,7 @@ static int __devinit chd_dec_init_chdev(struct crystalhd_adp *adp)
 
        dev = device_create(crystalhd_class, NULL, MKDEV(adp->chd_dec_major, 0),
                            NULL, "crystalhd");
-       if (!dev) {
+       if (IS_ERR(dev)) {
                BCMLOG_ERR("failed to create device\n");
                goto device_create_fail;
        }