drm/i915: Drop assertion that active->fence is unchanged
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 25 Feb 2020 08:22:23 +0000 (08:22 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 25 Feb 2020 15:52:19 +0000 (15:52 +0000)
We cannot assert the fence is not yet changed as the next thread may
change it prior to acquiring our lock.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200225082233.274530-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_active.c

index 9ccb931a733e8a087efb73dc3bf5d31425318505..992b00fc57456a95fe49c49f7fd8ba81ed7e419f 100644 (file)
@@ -823,7 +823,6 @@ __i915_active_fence_set(struct i915_active_fence *active,
                __list_del_entry(&active->cb.node);
                spin_unlock(prev->lock); /* serialise with prev->cb_list */
        }
-       GEM_BUG_ON(rcu_access_pointer(active->fence) != fence);
        list_add_tail(&active->cb.node, &fence->cb_list);
        spin_unlock_irqrestore(fence->lock, flags);