iwlwifi: mvm: drop low_latency_agg_frame_cnt_limit

This was an old workaround for solving latency issues with
certain Miracast adapters like ActionTec. However this isn't
needed anymore and furthermore it hurts throughput in other
use cases.

Signed-off-by: Eyal Shapira <eyalx.shapira@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
index 82a61f6c59d141a9d2bed8cd79851b0c84a1db43..48d5ee1b026c058c0f90d46133ec19111d9ad222 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c
@@ -1491,10 +1491,6 @@ int iwl_mvm_dbgfs_register(struct iwl_mvm *mvm, struct dentry *dbgfs_dir)
                goto err;
 #endif
 
-       if (!debugfs_create_u8("low_latency_agg_frame_limit", S_IRUSR | S_IWUSR,
-                              mvm->debugfs_dir,
-                              &mvm->low_latency_agg_frame_limit))
-               goto err;
        if (!debugfs_create_u8("ps_disabled", S_IRUSR,
                               mvm->debugfs_dir, &mvm->ps_disabled))
                goto err;

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
index ff32f3604bc005059b95dcb306696cd11cb556d9..f28e0501c5e50fbcded51e9b3255f6cf95110b76 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
@@ -813,8 +813,6 @@ struct iwl_mvm {
        bool lar_regdom_set;
        enum iwl_mcc_source mcc_src;
 
-       u8 low_latency_agg_frame_limit;
-
        /* TDLS channel switch data */
        struct {
                struct delayed_work dwork;

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
index 926492832be781bfc256812b18bef7c0a36f8d07..e9b400c7ed79ba4ff406df13069ab968b6458624 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
@@ -452,7 +452,6 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg,
                mvm->first_agg_queue = 12;
        }
        mvm->sf_state = SF_UNINIT;
-       mvm->low_latency_agg_frame_limit = 6;
        mvm->cur_ucode = IWL_UCODE_INIT;
 
        mutex_init(&mvm->mutex);

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
index d1ad10391b473fb0ff288f0311d9b7bd6f14921d..37c2db1c1b1c86654e1da43ed00a040734a088af 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
@@ -3454,15 +3454,9 @@ static void rs_fill_lq_cmd(struct iwl_mvm *mvm,
         * Tx Fifo so that it can start a transaction in the same TxOP. This
         * basically allows the firmware to send bursts.
         */
-       if (iwl_mvm_vif_low_latency(mvmvif)) {
+       if (iwl_mvm_vif_low_latency(mvmvif))
                lq_cmd->agg_frame_cnt_limit--;
 
-               if (mvm->low_latency_agg_frame_limit)
-                       lq_cmd->agg_frame_cnt_limit =
-                               min(lq_cmd->agg_frame_cnt_limit,
-                                   mvm->low_latency_agg_frame_limit);
-       }
-
        if (mvmsta->vif->p2p)
                lq_cmd->flags |= LQ_FLAG_USE_RTS_MSK;