[media] IX2505V: i2c transfer error code ignored
authorMatthias Schwarzott <zzam@gentoo.org>
Sun, 7 Nov 2010 13:57:13 +0000 (10:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 29 Dec 2010 10:16:46 +0000 (08:16 -0200)
It seems that ix2505v driver ignores a i2c error in ix2505v_read_status_reg.
This looks like a typing error using (ret = 1) instead of correct (ret == 1).

Acked-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Cc: stable@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/frontends/ix2505v.c

index 55f2eba7bc96f76a267bec9c288fd3d7cc5f719e..6360c681ded9672db8ef5e21fd6128b01eeba336 100644 (file)
@@ -72,7 +72,7 @@ static int ix2505v_read_status_reg(struct ix2505v_state *state)
        ret = i2c_transfer(state->i2c, msg, 1);
        deb_i2c("Read %s ", __func__);
 
-       return (ret = 1) ? (int) b2[0] : -1;
+       return (ret == 1) ? (int) b2[0] : -1;
 }
 
 static int ix2505v_write(struct ix2505v_state *state, u8 buf[], u8 count)