dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet
authorBarry Song <21cnbao@gmail.com>
Fri, 17 Aug 2018 13:00:26 +0000 (06:00 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 3 Sep 2018 10:53:00 +0000 (16:23 +0530)
as you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Signed-off-by: Barry Song <21cnbao@gmail.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/fsldma.c

index 1117b5123a6fc786f28d68868deef2fa10951d42..9d360a3fbae3123b2da8a2a5abf6780747ec88be 100644 (file)
@@ -987,7 +987,7 @@ static void dma_do_tasklet(unsigned long data)
 
        chan_dbg(chan, "tasklet entry\n");
 
-       spin_lock_bh(&chan->desc_lock);
+       spin_lock(&chan->desc_lock);
 
        /* the hardware is now idle and ready for more */
        chan->idle = true;
@@ -995,7 +995,7 @@ static void dma_do_tasklet(unsigned long data)
        /* Run all cleanup for descriptors which have been completed */
        fsldma_cleanup_descriptors(chan);
 
-       spin_unlock_bh(&chan->desc_lock);
+       spin_unlock(&chan->desc_lock);
 
        chan_dbg(chan, "tasklet exit\n");
 }