drm/amd/display: Block 3D Timings
authorJoshua Aberback <Joshua.Aberback@amd.com>
Tue, 29 Nov 2016 22:56:05 +0000 (17:56 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 26 Sep 2017 21:02:07 +0000 (17:02 -0400)
- we don't yet support 3D timings in DAL3
- somehow a code path was being executed that resulted in HW programming
for a 3D timing, which caused 3D displays to show half the desktop in one
frame, and the other half of the desktop in the next frame
- blocking all 3D timings in timing generator validation until we
implement proper 3D timing support

Signed-off-by: Joshua Aberback <Joshua.Aberback@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <Harry.Wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c

index b1c97125f6fb88afd41082a0f55211d76c089f55..12a258763ef1d92f2166f89b9c5c6f9200c2226a 100644 (file)
@@ -1113,6 +1113,10 @@ bool dce110_timing_generator_validate_timing(
        if (!timing)
                return false;
 
+       /* Currently we don't support 3D, so block all 3D timings */
+       if (timing->timing_3d_format != TIMING_3D_FORMAT_NONE)
+               return false;
+
        /* Check maximum number of pixels supported by Timing Generator
         * (Currently will never fail, in order to fail needs display which
         * needs more than 8192 horizontal and