drm/exynos: change callback names
authorInki Dae <inki.dae@samsung.com>
Thu, 19 Dec 2019 02:07:53 +0000 (11:07 +0900)
committerInki Dae <inki.dae@samsung.com>
Tue, 21 Jan 2020 00:09:42 +0000 (09:09 +0900)
This patch changes Exynos specific 'disable' and 'enable'
callback names to 'atomic_disable/enable' for the consistency.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos5433_drm_decon.c
drivers/gpu/drm/exynos/exynos7_drm_decon.c
drivers/gpu/drm/exynos/exynos_drm_crtc.c
drivers/gpu/drm/exynos/exynos_drm_drv.h
drivers/gpu/drm/exynos/exynos_drm_fimd.c
drivers/gpu/drm/exynos/exynos_drm_vidi.c
drivers/gpu/drm/exynos/exynos_mixer.c

index 2d5cbfda3ca79a7e087a69d742276b511aac6b06..8428ae12dfa5e8c4de938ac46c0689053d3609a5 100644 (file)
@@ -510,7 +510,7 @@ static void decon_swreset(struct decon_context *ctx)
               ctx->addr + DECON_CRCCTRL);
 }
 
-static void decon_enable(struct exynos_drm_crtc *crtc)
+static void decon_atomic_enable(struct exynos_drm_crtc *crtc)
 {
        struct decon_context *ctx = crtc->ctx;
 
@@ -523,7 +523,7 @@ static void decon_enable(struct exynos_drm_crtc *crtc)
        decon_commit(ctx->crtc);
 }
 
-static void decon_disable(struct exynos_drm_crtc *crtc)
+static void decon_atomic_disable(struct exynos_drm_crtc *crtc)
 {
        struct decon_context *ctx = crtc->ctx;
        int i;
@@ -599,8 +599,8 @@ static enum drm_mode_status decon_mode_valid(struct exynos_drm_crtc *crtc,
 }
 
 static const struct exynos_drm_crtc_ops decon_crtc_ops = {
-       .enable                 = decon_enable,
-       .disable                = decon_disable,
+       .atomic_enable          = decon_atomic_enable,
+       .atomic_disable         = decon_atomic_disable,
        .enable_vblank          = decon_enable_vblank,
        .disable_vblank         = decon_disable_vblank,
        .atomic_begin           = decon_atomic_begin,
@@ -651,7 +651,7 @@ static void decon_unbind(struct device *dev, struct device *master, void *data)
 {
        struct decon_context *ctx = dev_get_drvdata(dev);
 
-       decon_disable(ctx->crtc);
+       decon_atomic_disable(ctx->crtc);
 
        /* detach this sub driver from iommu mapping if supported. */
        exynos_drm_unregister_dma(ctx->drm_dev, ctx->dev);
index f0640950bd465b385f8e6bea55194c02b8fd7dd8..ff59c641fa809224b96972928c3b6ae6a5fb3c21 100644 (file)
@@ -526,7 +526,7 @@ static void decon_init(struct decon_context *ctx)
                writel(VIDCON1_VCLK_HOLD, ctx->regs + VIDCON1(0));
 }
 
-static void decon_enable(struct exynos_drm_crtc *crtc)
+static void decon_atomic_enable(struct exynos_drm_crtc *crtc)
 {
        struct decon_context *ctx = crtc->ctx;
 
@@ -546,7 +546,7 @@ static void decon_enable(struct exynos_drm_crtc *crtc)
        ctx->suspended = false;
 }
 
-static void decon_disable(struct exynos_drm_crtc *crtc)
+static void decon_atomic_disable(struct exynos_drm_crtc *crtc)
 {
        struct decon_context *ctx = crtc->ctx;
        int i;
@@ -568,8 +568,8 @@ static void decon_disable(struct exynos_drm_crtc *crtc)
 }
 
 static const struct exynos_drm_crtc_ops decon_crtc_ops = {
-       .enable = decon_enable,
-       .disable = decon_disable,
+       .atomic_enable = decon_atomic_enable,
+       .atomic_disable = decon_atomic_disable,
        .enable_vblank = decon_enable_vblank,
        .disable_vblank = decon_disable_vblank,
        .atomic_begin = decon_atomic_begin,
@@ -653,7 +653,7 @@ static void decon_unbind(struct device *dev, struct device *master,
 {
        struct decon_context *ctx = dev_get_drvdata(dev);
 
-       decon_disable(ctx->crtc);
+       decon_atomic_disable(ctx->crtc);
 
        if (ctx->encoder)
                exynos_dpi_remove(ctx->encoder);
index 77ce78986408b95f9d36977cf5ea064300479e1b..1c03485676efa33e04376a42480a4a2e1a9aec88 100644 (file)
@@ -23,8 +23,8 @@ static void exynos_drm_crtc_atomic_enable(struct drm_crtc *crtc,
 {
        struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
 
-       if (exynos_crtc->ops->enable)
-               exynos_crtc->ops->enable(exynos_crtc);
+       if (exynos_crtc->ops->atomic_enable)
+               exynos_crtc->ops->atomic_enable(exynos_crtc);
 
        drm_crtc_vblank_on(crtc);
 }
@@ -36,8 +36,8 @@ static void exynos_drm_crtc_atomic_disable(struct drm_crtc *crtc,
 
        drm_crtc_vblank_off(crtc);
 
-       if (exynos_crtc->ops->disable)
-               exynos_crtc->ops->disable(exynos_crtc);
+       if (exynos_crtc->ops->atomic_disable)
+               exynos_crtc->ops->atomic_disable(exynos_crtc);
 
        if (crtc->state->event && !crtc->state->active) {
                spin_lock_irq(&crtc->dev->event_lock);
index d4014ba592fdc1485e70ead1b5f73f0bde3fc23a..d4d21d8cfb9060169ab86bda8ef49b879eaa5b4a 100644 (file)
@@ -118,8 +118,8 @@ struct exynos_drm_plane_config {
 /*
  * Exynos drm crtc ops
  *
- * @enable: enable the device
- * @disable: disable the device
+ * @atomic_enable: enable the device
+ * @atomic_disable: disable the device
  * @enable_vblank: specific driver callback for enabling vblank interrupt.
  * @disable_vblank: specific driver callback for disabling vblank interrupt.
  * @mode_valid: specific driver callback for mode validation
@@ -133,8 +133,8 @@ struct exynos_drm_plane_config {
  */
 struct exynos_drm_crtc;
 struct exynos_drm_crtc_ops {
-       void (*enable)(struct exynos_drm_crtc *crtc);
-       void (*disable)(struct exynos_drm_crtc *crtc);
+       void (*atomic_enable)(struct exynos_drm_crtc *crtc);
+       void (*atomic_disable)(struct exynos_drm_crtc *crtc);
        int (*enable_vblank)(struct exynos_drm_crtc *crtc);
        void (*disable_vblank)(struct exynos_drm_crtc *crtc);
        enum drm_mode_status (*mode_valid)(struct exynos_drm_crtc *crtc,
index 8d0a929104e53b6d3ee810c7c48329f9984f7041..21aec38702fc2b731a1ae4a982ed15fced156175 100644 (file)
@@ -894,7 +894,7 @@ static void fimd_disable_plane(struct exynos_drm_crtc *crtc,
                fimd_enable_shadow_channel_path(ctx, win, false);
 }
 
-static void fimd_enable(struct exynos_drm_crtc *crtc)
+static void fimd_atomic_enable(struct exynos_drm_crtc *crtc)
 {
        struct fimd_context *ctx = crtc->ctx;
 
@@ -912,7 +912,7 @@ static void fimd_enable(struct exynos_drm_crtc *crtc)
        fimd_commit(ctx->crtc);
 }
 
-static void fimd_disable(struct exynos_drm_crtc *crtc)
+static void fimd_atomic_disable(struct exynos_drm_crtc *crtc)
 {
        struct fimd_context *ctx = crtc->ctx;
        int i;
@@ -1006,8 +1006,8 @@ static void fimd_dp_clock_enable(struct exynos_drm_clk *clk, bool enable)
 }
 
 static const struct exynos_drm_crtc_ops fimd_crtc_ops = {
-       .enable = fimd_enable,
-       .disable = fimd_disable,
+       .atomic_enable = fimd_atomic_enable,
+       .atomic_disable = fimd_atomic_disable,
        .enable_vblank = fimd_enable_vblank,
        .disable_vblank = fimd_disable_vblank,
        .atomic_begin = fimd_atomic_begin,
@@ -1098,7 +1098,7 @@ static void fimd_unbind(struct device *dev, struct device *master,
 {
        struct fimd_context *ctx = dev_get_drvdata(dev);
 
-       fimd_disable(ctx->crtc);
+       fimd_atomic_disable(ctx->crtc);
 
        exynos_drm_unregister_dma(ctx->drm_dev, ctx->dev);
 
index 65b891cb9c50b0f9ef570e8ab14407d9bd02babb..b320b3a21ad4f60e4efd373217861829cbdc363c 100644 (file)
@@ -120,7 +120,7 @@ static void vidi_update_plane(struct exynos_drm_crtc *crtc,
        DRM_DEV_DEBUG_KMS(ctx->dev, "dma_addr = %pad\n", &addr);
 }
 
-static void vidi_enable(struct exynos_drm_crtc *crtc)
+static void vidi_atomic_enable(struct exynos_drm_crtc *crtc)
 {
        struct vidi_context *ctx = crtc->ctx;
 
@@ -133,7 +133,7 @@ static void vidi_enable(struct exynos_drm_crtc *crtc)
        drm_crtc_vblank_on(&crtc->base);
 }
 
-static void vidi_disable(struct exynos_drm_crtc *crtc)
+static void vidi_atomic_disable(struct exynos_drm_crtc *crtc)
 {
        struct vidi_context *ctx = crtc->ctx;
 
@@ -147,8 +147,8 @@ static void vidi_disable(struct exynos_drm_crtc *crtc)
 }
 
 static const struct exynos_drm_crtc_ops vidi_crtc_ops = {
-       .enable = vidi_enable,
-       .disable = vidi_disable,
+       .atomic_enable = vidi_atomic_enable,
+       .atomic_disable = vidi_atomic_disable,
        .enable_vblank = vidi_enable_vblank,
        .disable_vblank = vidi_disable_vblank,
        .update_plane = vidi_update_plane,
index 6cfdb95fef2fa171ca34930265c416efbccec53c..38ae9c32feef594f398ab246582067604b9c29f7 100644 (file)
@@ -986,7 +986,7 @@ static void mixer_atomic_flush(struct exynos_drm_crtc *crtc)
        exynos_crtc_handle_event(crtc);
 }
 
-static void mixer_enable(struct exynos_drm_crtc *crtc)
+static void mixer_atomic_enable(struct exynos_drm_crtc *crtc)
 {
        struct mixer_context *ctx = crtc->ctx;
 
@@ -1015,7 +1015,7 @@ static void mixer_enable(struct exynos_drm_crtc *crtc)
        set_bit(MXR_BIT_POWERED, &ctx->flags);
 }
 
-static void mixer_disable(struct exynos_drm_crtc *crtc)
+static void mixer_atomic_disable(struct exynos_drm_crtc *crtc)
 {
        struct mixer_context *ctx = crtc->ctx;
        int i;
@@ -1109,8 +1109,8 @@ static bool mixer_mode_fixup(struct exynos_drm_crtc *crtc,
 }
 
 static const struct exynos_drm_crtc_ops mixer_crtc_ops = {
-       .enable                 = mixer_enable,
-       .disable                = mixer_disable,
+       .atomic_enable          = mixer_atomic_enable,
+       .atomic_disable         = mixer_atomic_disable,
        .enable_vblank          = mixer_enable_vblank,
        .disable_vblank         = mixer_disable_vblank,
        .atomic_begin           = mixer_atomic_begin,