PCI: mobiveil: Add Header Type field check
authorHou Zhiqiang <Zhiqiang.Hou@nxp.com>
Thu, 13 Feb 2020 04:06:40 +0000 (12:06 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 21 Feb 2020 11:53:22 +0000 (11:53 +0000)
Check the Header Type and exit from the host driver initialization if
it is not in host mode.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Andrew Murray <amurray@thegoodpenguin.co.uk>
drivers/pci/controller/mobiveil/pcie-mobiveil-host.c

index 209e75d24e3b4c2b1c002d056659c78d1d867d90..a94be264240ff427434a13cca8397d09a37d939c 100644 (file)
@@ -554,6 +554,16 @@ static int mobiveil_pcie_interrupt_init(struct mobiveil_pcie *pcie)
        return mobiveil_pcie_integrated_interrupt_init(pcie);
 }
 
+static bool mobiveil_pcie_is_bridge(struct mobiveil_pcie *pcie)
+{
+       u32 header_type;
+
+       header_type = mobiveil_csr_readb(pcie, PCI_HEADER_TYPE);
+       header_type &= 0x7f;
+
+       return header_type == PCI_HEADER_TYPE_BRIDGE;
+}
+
 int mobiveil_pcie_host_probe(struct mobiveil_pcie *pcie)
 {
        struct mobiveil_root_port *rp = &pcie->rp;
@@ -569,6 +579,9 @@ int mobiveil_pcie_host_probe(struct mobiveil_pcie *pcie)
                return ret;
        }
 
+       if (!mobiveil_pcie_is_bridge(pcie))
+               return -ENODEV;
+
        /* parse the host bridge base addresses from the device tree file */
        ret = pci_parse_request_of_pci_ranges(dev, &bridge->windows,
                                              &bridge->dma_ranges, NULL);