serial: Delete dead code for CIR serial ports
authorMatthias Brugger <mbrugger@suse.com>
Fri, 16 Jun 2017 15:17:14 +0000 (17:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jun 2017 02:24:15 +0000 (10:24 +0800)
Commit e4fda3a04275 ("serial: don't register CIR serial ports") adds a
check for PORT_8250_CIR to serial8250_register_8250_port(). But the code
isn't needed as the function never takes the branch when the port is CIR
serial port.

This patch deletes the dead code.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_core.c

index 1aab3010fbfae76e2c25cb60085f21051a1f24cf..b5def356af63b70e3ebc2e23a48da0753e41b47e 100644 (file)
@@ -1043,24 +1043,13 @@ int serial8250_register_8250_port(struct uart_8250_port *up)
                if (up->dl_write)
                        uart->dl_write = up->dl_write;
 
-               if (uart->port.type != PORT_8250_CIR) {
-                       if (serial8250_isa_config != NULL)
-                               serial8250_isa_config(0, &uart->port,
-                                               &uart->capabilities);
-
-                       ret = uart_add_one_port(&serial8250_reg,
-                                               &uart->port);
-                       if (ret == 0)
-                               ret = uart->port.line;
-               } else {
-                       dev_info(uart->port.dev,
-                               "skipping CIR port at 0x%lx / 0x%llx, IRQ %d\n",
-                               uart->port.iobase,
-                               (unsigned long long)uart->port.mapbase,
-                               uart->port.irq);
+               if (serial8250_isa_config != NULL)
+                       serial8250_isa_config(0, &uart->port,
+                                       &uart->capabilities);
 
-                       ret = 0;
-               }
+               ret = uart_add_one_port(&serial8250_reg, &uart->port);
+               if (ret == 0)
+                       ret = uart->port.line;
        }
        mutex_unlock(&serial_mutex);