sctp: use transport pf_retrans in sctp_do_8_2_transport_strike
authorXin Long <lucien.xin@gmail.com>
Mon, 2 Sep 2019 15:24:21 +0000 (23:24 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Sep 2019 22:29:21 +0000 (00:29 +0200)
Transport should use its own pf_retrans to do the error_count
check, instead of asoc's. Otherwise, it's meaningless to make
pf_retrans per transport.

Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sm_sideeffect.c

index 1cf5bb5b73c412cadf1b3d7240bb8c200edb77a5..e52b2128e43b8706ddbec3d6b77388e24402c1c9 100644 (file)
@@ -547,7 +547,7 @@ static void sctp_do_8_2_transport_strike(struct sctp_cmd_seq *commands,
        if (net->sctp.pf_enable &&
           (transport->state == SCTP_ACTIVE) &&
           (transport->error_count < transport->pathmaxrxt) &&
-          (transport->error_count > asoc->pf_retrans)) {
+          (transport->error_count > transport->pf_retrans)) {
 
                sctp_assoc_control_transport(asoc, transport,
                                             SCTP_TRANSPORT_PF,