i810: fix module_param bool abuse.
authorRusty Russell <rusty@rustcorp.com.au>
Thu, 15 Dec 2011 03:03:56 +0000 (13:33 +1030)
committerFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
Mon, 19 Dec 2011 20:21:55 +0000 (20:21 +0000)
The driver says "module_param(ddc3, bool, 0);".  But it's not a used
as a bool, it's used as a count.

Make it a bool.

Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
drivers/video/i810/i810_main.c

index 318f6fb895b289d2c2b5b884dd7deebc8e1616cf..5a4ac3c85331e5a750d14b01f691cbb0f2089dde 100644 (file)
@@ -147,7 +147,7 @@ static int vyres      __devinitdata;
 static int sync       __devinitdata;
 static int extvga     __devinitdata;
 static int dcolor     __devinitdata;
-static int ddc3       __devinitdata = 2;
+static bool ddc3      __devinitdata;
 
 /*------------------------------------------------------------*/
 
@@ -1776,7 +1776,7 @@ static void __devinit i810_init_defaults(struct i810fb_par *par,
        if (sync) 
                par->dev_flags |= ALWAYS_SYNC;
 
-       par->ddc_num = ddc3;
+       par->ddc_num = (ddc3 ? 3 : 2);
 
        if (bpp < 8)
                bpp = 8;
@@ -1999,7 +1999,7 @@ static int __devinit i810fb_setup(char *options)
                else if (!strncmp(this_opt, "dcolor", 6))
                        dcolor = 1;
                else if (!strncmp(this_opt, "ddc3", 4))
-                       ddc3 = 3;
+                       ddc3 = true;
                else
                        mode_option = this_opt;
        }