media: imx: Clear fwnode link struct for each endpoint iteration

In imx_media_create_csi_of_links(), the 'struct v4l2_fwnode_link' must
be cleared for each endpoint iteration, otherwise if the remote port
has no "reg" property, link.remote_port will not be reset to zero.
This was discovered on the i.MX53 SMD board, since the OV5642 connects
directly to ipu1_csi0 and has a single source port with no "reg"
property.

Fixes: 621b08eabcddb ("media: staging/imx: remove static media link arrays")
Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c
index 03446335ac033a39ee9fec875221f6b472ab265d..a26bdeb1af34d28fa03f9f3f42c2aaf18521f8f1 100644 (file)
--- a/drivers/staging/media/imx/imx-media-of.c
+++ b/drivers/staging/media/imx/imx-media-of.c
@@ -145,15 +145,18 @@ int imx_media_create_csi_of_links(struct imx_media_dev *imxmd,
                                  struct v4l2_subdev *csi)
 {
        struct device_node *csi_np = csi->dev->of_node;
-       struct fwnode_handle *fwnode, *csi_ep;
-       struct v4l2_fwnode_link link;
        struct device_node *ep;
-       int ret;
-
-       link.local_node = of_fwnode_handle(csi_np);
-       link.local_port = CSI_SINK_PAD;
 
        for_each_child_of_node(csi_np, ep) {
+               struct fwnode_handle *fwnode, *csi_ep;
+               struct v4l2_fwnode_link link;
+               int ret;
+
+               memset(&link, 0, sizeof(link));
+
+               link.local_node = of_fwnode_handle(csi_np);
+               link.local_port = CSI_SINK_PAD;
+
                csi_ep = of_fwnode_handle(ep);
 
                fwnode = fwnode_graph_get_remote_endpoint(csi_ep);