net: tls: Fix deadlock in free_resources tx
authorDave Watson <davejwatson@fb.com>
Sun, 27 Jan 2019 00:59:03 +0000 (00:59 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Jan 2019 07:07:08 +0000 (23:07 -0800)
If there are outstanding async tx requests (when crypto returns EINPROGRESS),
there is a potential deadlock: the tx work acquires the lock, while we
cancel_delayed_work_sync() while holding the lock.  Drop the lock while waiting
for the work to complete.

Fixes: a42055e8d2c30 ("Add support for async encryption of records...")
Signed-off-by: Dave Watson <davejwatson@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tls/tls_sw.c

index 7e963560edefad7db87bf2ad47761155fd27baeb..bf5b54b513bc70e74f8df3d2554df2b7f87d4b4f 100644 (file)
@@ -1794,7 +1794,9 @@ void tls_sw_free_resources_tx(struct sock *sk)
        if (atomic_read(&ctx->encrypt_pending))
                crypto_wait_req(-EINPROGRESS, &ctx->async_wait);
 
+       release_sock(sk);
        cancel_delayed_work_sync(&ctx->tx_work.work);
+       lock_sock(sk);
 
        /* Tx whatever records we can transmit and abandon the rest */
        tls_tx_records(sk, -1);