PCI: armada8k: Fix platform_get_irq() error handling
authorFabio Estevam <fabio.estevam@nxp.com>
Thu, 31 Aug 2017 17:52:03 +0000 (14:52 -0300)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 5 Sep 2017 18:30:32 +0000 (13:30 -0500)
platform_get_irq() returns a negative number on failure, so adjust the
logic to detect such condition and propagate the real error value on
failure.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
drivers/pci/dwc/pcie-armada8k.c

index 729722366c634b57d492113034be9f20bbcd3f86..8047686c38565f7f224c5cbb49c4d5d39c998ed9 100644 (file)
@@ -176,9 +176,9 @@ static int armada8k_add_pcie_port(struct armada8k_pcie *pcie,
        pp->ops = &armada8k_pcie_host_ops;
 
        pp->irq = platform_get_irq(pdev, 0);
-       if (!pp->irq) {
+       if (pp->irq < 0) {
                dev_err(dev, "failed to get irq for port\n");
-               return -ENODEV;
+               return pp->irq;
        }
 
        ret = devm_request_irq(dev, pp->irq, armada8k_pcie_irq_handler,