staging: iio: adc: Remove unnecessary test from if conditions

Remove unnecessary test condition on ret variable which has been
previously tested and returns its value if the value is non zero.

This fixes the following smatch warnings:
drivers/staging/iio/adc/ad7816.c:299 ad7816_set_oti() warn: we tested
'ret' before and it was 'false'
drivers/staging/iio/adc/ad7816.c:306 ad7816_set_oti() warn: we tested
'ret' before and it was 'false'

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index 22260512cf01e5eb61d29b8c4e47819e63b7d776..ac3735c7f4a94a30dd2859bd6633fd7a739fb2d2 100644 (file)
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc/ad7816.c
@@ -296,14 +296,14 @@ static inline ssize_t ad7816_set_oti(struct device *dev,
                dev_err(dev, "Invalid oti channel id %d.\n", chip->channel_id);
                return -EINVAL;
        } else if (chip->channel_id == 0) {
-               if (ret || value < AD7816_BOUND_VALUE_MIN ||
+               if (value < AD7816_BOUND_VALUE_MIN ||
                    value > AD7816_BOUND_VALUE_MAX)
                        return -EINVAL;
 
                data = (u8)(value - AD7816_BOUND_VALUE_MIN +
                        AD7816_BOUND_VALUE_BASE);
        } else {
-               if (ret || value < AD7816_BOUND_VALUE_BASE || value > 255)
+               if (value < AD7816_BOUND_VALUE_BASE || value > 255)
                        return -EINVAL;
 
                data = (u8)value;