drm/amd/display: do not need otg lock if otg is not active
authorhersen wu <hersenxs.wu@amd.com>
Wed, 13 Mar 2019 20:19:17 +0000 (16:19 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Sat, 22 Jun 2019 14:34:08 +0000 (09:34 -0500)
[todo] need find caller bug. tempooariy fix

Signed-off-by: hersen wu <hersenxs.wu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c

index b3fc71648d1654defb09d8e065279cb17c216f3c..a546c2bc9129c7dbee1d4fc0fadb64bfaf40f69a 100644 (file)
@@ -584,6 +584,13 @@ uint32_t optc1_get_vblank_counter(struct timing_generator *optc)
 void optc1_lock(struct timing_generator *optc)
 {
        struct optc *optc1 = DCN10TG_FROM_TG(optc);
+       uint32_t regval = 0;
+
+       regval = REG_READ(OTG_CONTROL);
+
+       /* otg is not running, do not need to be locked */
+       if ((regval & 0x1) == 0x0)
+               return;
 
        REG_SET(OTG_GLOBAL_CONTROL0, 0,
                        OTG_MASTER_UPDATE_LOCK_SEL, optc->inst);
@@ -591,10 +598,12 @@ void optc1_lock(struct timing_generator *optc)
                        OTG_MASTER_UPDATE_LOCK, 1);
 
        /* Should be fast, status does not update on maximus */
-       if (optc->ctx->dce_environment != DCE_ENV_FPGA_MAXIMUS)
+       if (optc->ctx->dce_environment != DCE_ENV_FPGA_MAXIMUS) {
+
                REG_WAIT(OTG_MASTER_UPDATE_LOCK,
                                UPDATE_LOCK_STATUS, 1,
                                1, 10);
+       }
 }
 
 void optc1_unlock(struct timing_generator *optc)