staging: ccree: use signal safe completion wait
authorGilad Ben-Yossef <gilad@benyossef.com>
Sun, 25 Jun 2017 07:47:24 +0000 (10:47 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Jun 2017 14:29:15 +0000 (16:29 +0200)
We were waiting for a completion notification of HW DMA
operation using an interruptible wait which can result
in data corruption if a signal interrupted us while
DMA was not yet completed.

Fix this by moving to uninterrupted wait.

Fixes: abefd6741d ("staging: ccree: introduce CryptoCell HW driver").
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_request_mgr.c

index 7c2d88a8fe601c4d71a30c6542cb96548074804f..2c6937af995d30f5ef62e7ecabd681dd931d0ea0 100644 (file)
@@ -382,7 +382,8 @@ int send_request(
                /* Wait upon sequence completion.
                 *  Return "0" -Operation done successfully.
                 */
-               return wait_for_completion_interruptible(&ssi_req->seq_compl);
+               wait_for_completion(&ssi_req->seq_compl);
+               return 0;
        } else {
                /* Operation still in process */
                return -EINPROGRESS;