ARM: omap: dma: get rid of errata global
authorRussell King <rmk+kernel@arm.linux.org.uk>
Fri, 8 Nov 2013 18:06:37 +0000 (18:06 +0000)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Thu, 3 Apr 2014 23:31:45 +0000 (00:31 +0100)
There's no need for this to be a global variable; move it into the
errata configuration function instead.

Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/mach-omap1/dma.c
arch/arm/mach-omap2/dma.c

index b680db7a35d4d3e79262e33ad80a2a7cf1117fed..c979e3f88bbb51f040b101b195619909a3edbe7e 100644 (file)
@@ -33,7 +33,6 @@
 #define OMAP1_DMA_BASE                 (0xfffed800)
 #define OMAP1_LOGICAL_DMA_CH_COUNT     17
 
-static u32 errata;
 static u32 enable_1510_mode;
 
 static const struct omap_dma_reg reg_map[] = {
@@ -244,8 +243,9 @@ static void omap1_show_dma_caps(void)
        return;
 }
 
-static u32 configure_dma_errata(void)
+static unsigned configure_dma_errata(void)
 {
+       unsigned errata = 0;
 
        /*
         * Erratum 3.2/3.3: sometimes 0 is returned if CSAC/CDAC is
index e633b48a3fcbab8bbdea8b5d37deefdf62170702..244ff5012aeddf8a3583b6ddfdebff24f12c76ea 100644 (file)
@@ -35,8 +35,6 @@
 #include "omap_hwmod.h"
 #include "omap_device.h"
 
-static u32 errata;
-
 static struct omap_dma_dev_attr *d;
 
 static enum omap_reg_offsets dma_common_ch_end;
@@ -124,8 +122,9 @@ static void omap2_show_dma_caps(void)
        return;
 }
 
-static u32 configure_dma_errata(void)
+static unsigned configure_dma_errata(void)
 {
+       unsigned errata = 0;
 
        /*
         * Errata applicable for OMAP2430ES1.0 and all omap2420