[ARM] pxa/pcm990: don't use pxa_camera init() callback
authorAntonio Ospite <ospite@studenti.unina.it>
Fri, 27 Nov 2009 20:31:36 +0000 (21:31 +0100)
committerEric Miao <eric.y.miao@gmail.com>
Tue, 1 Dec 2009 01:03:14 +0000 (09:03 +0800)
pxa_camera init() is ambiguous, it's better to configure PXA CIF pins
statically in machine init function.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
arch/arm/mach-pxa/pcm990-baseboard.c

index bbda57078e0f71915fd489a00d274c6cc654d890..d5255ae74fe37218d7c548e65e6aa9c2706e9a39 100644 (file)
@@ -359,19 +359,12 @@ static unsigned long pcm990_camera_pin_config[] = {
        GPIO44_CIF_LV,
 };
 
-static int pcm990_pxacamera_init(struct device *dev)
-{
-       pxa2xx_mfp_config(ARRAY_AND_SIZE(pcm990_camera_pin_config));
-       return 0;
-}
-
 /*
  * CICR4: PCLK_EN:     Pixel clock is supplied by the sensor
  *     MCLK_EN:        Master clock is generated by PXA
  *     PCP:            Data sampled on the falling edge of pixel clock
  */
 struct pxacamera_platform_data pcm990_pxacamera_platform_data = {
-       .init   = pcm990_pxacamera_init,
        .flags  = PXA_CAMERA_MASTER | PXA_CAMERA_DATAWIDTH_8 | PXA_CAMERA_DATAWIDTH_10 |
                PXA_CAMERA_PCLK_EN | PXA_CAMERA_MCLK_EN/* | PXA_CAMERA_PCP*/,
        .mclk_10khz = 1000,
@@ -532,6 +525,7 @@ void __init pcm990_baseboard_init(void)
        pxa_set_ac97_info(NULL);
 
 #if defined(CONFIG_VIDEO_PXA27x) || defined(CONFIG_VIDEO_PXA27x_MODULE)
+       pxa2xx_mfp_config(ARRAY_AND_SIZE(pcm990_camera_pin_config));
        pxa_set_camera_info(&pcm990_pxacamera_platform_data);
 
        i2c_register_board_info(0, ARRAY_AND_SIZE(pcm990_i2c_devices));