gpu: ipu-v3: Stop overwriting pdev->dev.of_node of child devices
authorPhilipp Zabel <p.zabel@pengutronix.de>
Thu, 16 Feb 2017 13:46:31 +0000 (14:46 +0100)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Fri, 17 Feb 2017 07:04:27 +0000 (08:04 +0100)
Setting dev->of_node changes the modalias and breaks module autoloading.
Since there is an of_node field in the platform data passed to child
devices, we don't even need this anymore.

Suggested-by: Russell King <linux@armlinux.org.uk>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/gpu/ipu-v3/ipu-common.c

index 97218af4fe75cbc218fc537803885b26a89399b4..8368e6f766ee584b2947664d0f77e2b044410510 100644 (file)
@@ -1238,12 +1238,6 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base)
                        platform_device_put(pdev);
                        goto err_register;
                }
-
-               /*
-                * Set of_node only after calling platform_device_add. Otherwise
-                * the platform:imx-ipuv3-crtc modalias won't be used.
-                */
-               pdev->dev.of_node = of_node;
        }
 
        return 0;