drm/i915: Use vblank_disable_immediate on gen2
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 22 Mar 2019 18:08:04 +0000 (20:08 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 25 Mar 2019 06:40:20 +0000 (08:40 +0200)
The vblank timestamp->counter guesstimator seems to be
working sufficiently well, so there's no reason not to
disable vblank interrupts ASAP even on gen2.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190322180804.3300-2-ville.syrjala@linux.intel.com
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/i915_irq.c

index fcbe173ddddddf7faec84689de64a634f6d75709..455b2bf691b5ca3322c9dcc5da29b634b554bf13 100644 (file)
@@ -4642,13 +4642,7 @@ void intel_irq_init(struct drm_i915_private *dev_priv)
        else if (INTEL_GEN(dev_priv) >= 3)
                dev->driver->get_vblank_counter = i915_get_vblank_counter;
 
-       /*
-        * Opt out of the vblank disable timer on everything except gen2.
-        * Gen2 doesn't have a hardware frame counter and so depends on
-        * vblank interrupts to produce sane vblank seuquence numbers.
-        */
-       if (!IS_GEN(dev_priv, 2))
-               dev->vblank_disable_immediate = true;
+       dev->vblank_disable_immediate = true;
 
        /* Most platforms treat the display irq block as an always-on
         * power domain. vlv/chv can disable it at runtime and need