gpu: gma500: remove unneeded DRIVER_LICENSE #define
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Nov 2017 14:16:32 +0000 (15:16 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 20 Nov 2017 10:16:31 +0000 (11:16 +0100)
There is no need to #define the license of the driver, just put it in
the MODULE_LICENSE() line directly as a text string.

This allows tools that check that the module license matches the source
code license to work properly, as there is no need to unwind the
unneeded dereference, especially when the string is defined in a .h file
far away from the .c file it is used in.

Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20171117141632.GA17880@kroah.com
drivers/gpu/drm/gma500/psb_drv.c
drivers/gpu/drm/gma500/psb_drv.h

index 37a3be71acd909d6eb6ed7e9de2ed0175459dbb8..8f5cc1f471cd2bd373cfa6d4fdb2c9bcbda0cc01 100644 (file)
@@ -527,4 +527,4 @@ module_exit(psb_exit);
 
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE(DRIVER_LICENSE);
+MODULE_LICENSE("GPL");
index 821497dbd3fcbee99b2feb4e7a2890b2b40f213f..4918efc57b7ab79030b41275357c2ee7b0fead48 100644 (file)
@@ -36,7 +36,6 @@
 #include "mmu.h"
 
 #define DRIVER_AUTHOR "Alan Cox <alan@linux.intel.com> and others"
-#define DRIVER_LICENSE "GPL"
 
 #define DRIVER_NAME "gma500"
 #define DRIVER_DESC "DRM driver for the Intel GMA500, GMA600, GMA3600, GMA3650"