staging: most: remove redundant call to wake_up_interruptible
authorChristian Gromm <christian.gromm@microchip.com>
Tue, 22 Dec 2015 09:53:00 +0000 (10:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Feb 2016 01:34:58 +0000 (17:34 -0800)
This patch prevents the cdev module from rousing the channel wait queue in
case the channel is about to be closed. It is safe to do so, because the
application can not be waiting within read or write and at the same time
be calling close.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/most/aim-cdev/cdev.c

index 0141293b4bf54933e3be0aab210dcd62e79eb4a0..fd2ac898628e5fe70f3798072654e076dbd47451 100644 (file)
@@ -127,7 +127,6 @@ static int aim_close(struct inode *inode, struct file *filp)
                kfifo_free(&channel->fifo);
                list_del(&channel->list);
                ida_simple_remove(&minor_id, MINOR(channel->devno));
-               wake_up_interruptible(&channel->wq);
                kfree(channel);
                return 0;
        }
@@ -139,7 +138,6 @@ static int aim_close(struct inode *inode, struct file *filp)
                most_put_mbo(channel->stacked_mbo);
        ret = most_stop_channel(channel->iface, channel->channel_id, &cdev_aim);
        atomic_dec(&channel->access_ref);
-       wake_up_interruptible(&channel->wq);
        return ret;
 }