irqchip/mbigen: Stop printing kernel addresses
authorKefeng Wang <wangkefeng.wang@huawei.com>
Tue, 18 Jun 2019 09:15:05 +0000 (17:15 +0800)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 18 Jun 2019 09:27:02 +0000 (10:27 +0100)
After commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
it will print "____ptrval____" instead of actual addresses when mbigen
create domain fails,

  Hisilicon MBIGEN-V2 HISI0152:00: Failed to create mbi-gen@(____ptrval____) irqdomain
  Hisilicon MBIGEN-V2: probe of HISI0152:00 failed with error -12

dev_xxx() helper contains the device info, HISI0152:00, which stands for
mbigen ACPI HID and its UID, we can identify the failing probed mbigen,
so just remove the printing "mgn_chip->base", and also add missing "\n".

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-mbigen.c

index 98b6e1d4b1a68cf8a247f4c75a67d09fd11b6b08..c0f65ea0ae0faecd1e3da769549adc9a127a90ab 100644 (file)
@@ -355,8 +355,7 @@ static int mbigen_device_probe(struct platform_device *pdev)
                err = -EINVAL;
 
        if (err) {
-               dev_err(&pdev->dev, "Failed to create mbi-gen@%p irqdomain",
-                       mgn_chip->base);
+               dev_err(&pdev->dev, "Failed to create mbi-gen irqdomain\n");
                return err;
        }