net-snmp: fix inbound firewall rule support
authorHans Dedecker <dedeckeh@gmail.com>
Mon, 6 Nov 2017 10:39:14 +0000 (11:39 +0100)
committerHans Dedecker <dedeckeh@gmail.com>
Sat, 11 Nov 2017 17:06:03 +0000 (18:06 +0100)
Commit ae5ee6ba6c506b42d942c98349b3a54181790ec8 added support for inbound
firewall rule support but some corner cases were not covered.

In case net-snmp is started and the network interface is already up
the procd firewall rule is created but not applied by fw3 as
service_started calling procd_set_config_changed firewall was missing.

When stopping net-snmp clean up the net-snmp inbound firewall rules in
iptables by calling procd_set_config_changed firewall in stop_service
which will trigger fw3 to remove the inbound firewall rules.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
net/net-snmp/Makefile
net/net-snmp/files/snmpd.init

index 0237a54da5f1818213ed397d655874050c7c4596..fbe6df8b2f3587d2742821a6792f364289a3596d 100644 (file)
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=net-snmp
 PKG_VERSION:=5.7.3
-PKG_RELEASE:=9
+PKG_RELEASE:=10
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 PKG_SOURCE_URL:=@SF/net-snmp
index caffecf6640778f22d6f0742e6f56b73a04c9721..2b60fe05df9ab3c47f1fae211cd513fc9e38c436 100644 (file)
@@ -325,6 +325,7 @@ start_service() {
 
 stop_service() {
        [ -f "$CONFIGFILE" ] && rm -f "$CONFIGFILE"
+       procd_set_config_changed firewall
 }
 
 service_triggers(){
@@ -337,3 +338,7 @@ service_triggers(){
 
        procd_add_reload_trigger 'snmpd'
 }
+
+service_started() {
+       procd_set_config_changed firewall
+}