blk-throttle: return proper bool type to caller instead of 0/1
authorChengguang Xu <cgxu519@gmx.com>
Tue, 29 May 2018 10:32:44 +0000 (18:32 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 30 May 2018 18:48:22 +0000 (12:48 -0600)
Change to return true/false only for bool type return code.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-throttle.c

index 35bed770664d13c807ea770155f1d1f02ffedd8d..82282e6fdcf82cb1b662c1eac468e8de71d6826d 100644 (file)
@@ -819,7 +819,7 @@ static bool throtl_slice_used(struct throtl_grp *tg, bool rw)
        if (time_in_range(jiffies, tg->slice_start[rw], tg->slice_end[rw]))
                return false;
 
-       return 1;
+       return true;
 }
 
 /* Trim the used slices and adjust slice start accordingly */
@@ -929,7 +929,7 @@ static bool tg_with_in_iops_limit(struct throtl_grp *tg, struct bio *bio,
 
        if (wait)
                *wait = jiffy_wait;
-       return 0;
+       return false;
 }
 
 static bool tg_with_in_bps_limit(struct throtl_grp *tg, struct bio *bio,
@@ -972,7 +972,7 @@ static bool tg_with_in_bps_limit(struct throtl_grp *tg, struct bio *bio,
        jiffy_wait = jiffy_wait + (jiffy_elapsed_rnd - jiffy_elapsed);
        if (wait)
                *wait = jiffy_wait;
-       return 0;
+       return false;
 }
 
 /*
@@ -1022,7 +1022,7 @@ static bool tg_may_dispatch(struct throtl_grp *tg, struct bio *bio,
            tg_with_in_iops_limit(tg, bio, &iops_wait)) {
                if (wait)
                        *wait = 0;
-               return 1;
+               return true;
        }
 
        max_wait = max(bps_wait, iops_wait);
@@ -1033,7 +1033,7 @@ static bool tg_may_dispatch(struct throtl_grp *tg, struct bio *bio,
        if (time_before(tg->slice_end[rw], jiffies + max_wait))
                throtl_extend_slice(tg, rw, jiffies + max_wait);
 
-       return 0;
+       return false;
 }
 
 static void throtl_charge_bio(struct throtl_grp *tg, struct bio *bio)