staging: vc04_services: Remove VCHIQ_SERVICE_PARAMS_T typedef

Typedefing structs is not encouraged in the kernel.

Signed-off-by: Dominic Braun <inf.braun@fau.de>
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 13985501a8c0c38b6f83ba5672dec862eac012cf..3491fa6a07323702694fee27d8ace06ccdeffb0f 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -331,7 +331,7 @@ EXPORT_SYMBOL(vchiq_connect);
 
 VCHIQ_STATUS_T vchiq_add_service(
        VCHIQ_INSTANCE_T              instance,
-       const VCHIQ_SERVICE_PARAMS_T *params,
+       const struct vchiq_service_params *params,
        VCHIQ_SERVICE_HANDLE_T       *phandle)
 {
        VCHIQ_STATUS_T status;
@@ -370,7 +370,7 @@ EXPORT_SYMBOL(vchiq_add_service);
 
 VCHIQ_STATUS_T vchiq_open_service(
        VCHIQ_INSTANCE_T              instance,
-       const VCHIQ_SERVICE_PARAMS_T *params,
+       const struct vchiq_service_params *params,
        VCHIQ_SERVICE_HANDLE_T       *phandle)
 {
        VCHIQ_STATUS_T   status = VCHIQ_ERROR;
@@ -2328,7 +2328,7 @@ vchiq_keepalive_thread_func(void *v)
        VCHIQ_INSTANCE_T instance;
        VCHIQ_SERVICE_HANDLE_T ka_handle;
 
-       VCHIQ_SERVICE_PARAMS_T params = {
+       struct vchiq_service_params params = {
                .fourcc      = VCHIQ_MAKE_FOURCC('K', 'E', 'E', 'P'),
                .callback    = vchiq_keepalive_vchiq_callback,
                .version     = KEEPALIVE_VER,

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 628b0adacc573ad2ab2f8f64371e5671250b645a..7fe032abd267b2018a72ee80858ea49b31a16304 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -2303,7 +2303,7 @@ fail_free_handler_thread:
 /* Called from application thread when a client or server service is created. */
 VCHIQ_SERVICE_T *
 vchiq_add_service_internal(VCHIQ_STATE_T *state,
-       const VCHIQ_SERVICE_PARAMS_T *params, int srvstate,
+       const struct vchiq_service_params *params, int srvstate,
        VCHIQ_INSTANCE_T instance, VCHIQ_USERDATA_TERM_T userdata_term)
 {
        VCHIQ_SERVICE_T *service;

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
index 3d7a15b9b786a9cd8d787656021f327d75f6a781..62d914108183b9e0185bb5c3719af629547c4ec6 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
@@ -531,7 +531,7 @@ vchiq_connect_internal(VCHIQ_STATE_T *state, VCHIQ_INSTANCE_T instance);
 
 extern VCHIQ_SERVICE_T *
 vchiq_add_service_internal(VCHIQ_STATE_T *state,
-       const VCHIQ_SERVICE_PARAMS_T *params, int srvstate,
+       const struct vchiq_service_params *params, int srvstate,
        VCHIQ_INSTANCE_T instance, VCHIQ_USERDATA_TERM_T userdata_term);
 
 extern VCHIQ_STATUS_T

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
index aaf1bee3ca0cd738d981dfd36935cd4d30727eab..13ed23eacfae5dc0c262b4eca7fd04a06b19b917 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
@@ -103,13 +103,13 @@ struct vchiq_service_base {
        void *userdata;
 };
 
-typedef struct vchiq_service_params_struct {
+struct vchiq_service_params {
        int fourcc;
        VCHIQ_CALLBACK_T callback;
        void *userdata;
        short version;       /* Increment for non-trivial changes */
        short version_min;   /* Update for incompatible changes */
-} VCHIQ_SERVICE_PARAMS_T;
+};
 
 struct vchiq_config {
        unsigned int max_msg_size;
@@ -129,10 +129,10 @@ extern VCHIQ_STATUS_T vchiq_initialise(VCHIQ_INSTANCE_T *pinstance);
 extern VCHIQ_STATUS_T vchiq_shutdown(VCHIQ_INSTANCE_T instance);
 extern VCHIQ_STATUS_T vchiq_connect(VCHIQ_INSTANCE_T instance);
 extern VCHIQ_STATUS_T vchiq_add_service(VCHIQ_INSTANCE_T instance,
-       const VCHIQ_SERVICE_PARAMS_T *params,
+       const struct vchiq_service_params *params,
        VCHIQ_SERVICE_HANDLE_T *pservice);
 extern VCHIQ_STATUS_T vchiq_open_service(VCHIQ_INSTANCE_T instance,
-       const VCHIQ_SERVICE_PARAMS_T *params,
+       const struct vchiq_service_params *params,
        VCHIQ_SERVICE_HANDLE_T *pservice);
 extern VCHIQ_STATUS_T vchiq_close_service(VCHIQ_SERVICE_HANDLE_T service);
 extern VCHIQ_STATUS_T vchiq_remove_service(VCHIQ_SERVICE_HANDLE_T service);

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
index 9e21d1c472dea9639c124aa2b3eb463200573554..80c246c033b2b92132e0c3264c95345b3fd0a76c 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
@@ -41,7 +41,7 @@
 #define VCHIQ_INVALID_HANDLE (~0)
 
 struct vchiq_create_service {
-       VCHIQ_SERVICE_PARAMS_T params;
+       struct vchiq_service_params params;
        int is_open;
        int is_vchi;
        unsigned int handle;       /* OUT */

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 022af529c664f7874ca231e492f8490281e88b46..0a4e379da03e84603c5c337389139a899116308f 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -639,7 +639,7 @@ int32_t vchi_service_open(VCHI_INSTANCE_T instance_handle,
        *handle = (VCHI_SERVICE_HANDLE_T)service;
 
        if (service) {
-               VCHIQ_SERVICE_PARAMS_T params;
+               struct vchiq_service_params params;
                VCHIQ_STATUS_T status;
 
                memset(&params, 0, sizeof(params));