[media] af9033: fix AF9033 DVBv3 signal strength measurement
authorAntti Palosaari <crope@iki.fi>
Mon, 3 Nov 2014 23:24:13 +0000 (20:24 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 4 Nov 2014 20:19:27 +0000 (18:19 -0200)
Previous patch changes used signal strength firmware register from
0x800048 to 0x80004a in case of AF9033/AF9035 chip. In practice
reported values were running upside-down, when RR strength increases
reported value decreases and vice versa. That is because of 0x80004a
returns values that are dBm scale, but negative RF strength dBm
returned as positive number.

0x800048 returns 0-100, like percentage
0x80004a returns 0-255 dBm, without a negative sign

So restore old measurement now.

Cc: Bimow Chen <Bimow.Chen@ite.com.tw>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/af9033.c

index 2b3d2f06c01b6edceb03ade6c83762a3eaefeeb3..e3bae773787491fa6dcb40c5a3acf448aceb3be7 100644 (file)
@@ -867,7 +867,11 @@ static int af9033_read_signal_strength(struct dvb_frontend *fe, u16 *strength)
        u8 u8tmp, gain_offset, buf[7];
 
        if (dev->is_af9035) {
-               ret = af9033_rd_reg(dev, 0x80004a, &u8tmp);
+               /* read signal strength of 0-100 scale */
+               ret = af9033_rd_reg(dev, 0x800048, &u8tmp);
+               if (ret < 0)
+                       goto err;
+
                /* scale value to 0x0000-0xffff */
                *strength = u8tmp * 0xffff / 100;
        } else {