staging: bcm2835-audio: fix memory leak in bcm2835_audio_open_connection()

In bcm2835_audio_open_connection(), if VCHI connection fails or
initialisation of VCHI audio instance fails vchi_instance needs to be
deallocated otherwise it will cause a memory leak.

Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
index af16d0f3e2b302dbbd248eb974089b83a319155a..6e007db9d694fd4beeb6ad5dc7e334405207ec9f 100644 (file)
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
@@ -446,6 +446,7 @@ static int bcm2835_audio_open_connection(struct bcm2835_alsa_stream *alsa_stream
        LOG_DBG(" success !\n");
        ret = 0;
 err_free_mem:
+       kfree(vchi_instance);
        LOG_DBG(" .. OUT\n");
 
        return ret;